Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2E: Have a common function to install BMO and Ironic #1494

Merged
merged 1 commit into from
Jan 8, 2024
Merged

🌱 E2E: Have a common function to install BMO and Ironic #1494

merged 1 commit into from
Jan 8, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 18, 2023

This PR refactors and uses a common function to install ironic and bmo. This will be useful later should we have to install other stuff with kustomize.

@metal3-io-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Dec 18, 2023

/metal3-bmo-e2e-test

@mquhuy mquhuy marked this pull request as ready for review December 18, 2023 13:06
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Dec 18, 2023

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/common.go Outdated Show resolved Hide resolved
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/refactor-e2e branch 3 times, most recently from fb79236 to 96c5c8e Compare December 21, 2023 11:04
@mquhuy mquhuy requested a review from lentzi90 December 21, 2023 11:04
lentzi90
lentzi90 reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@lentzi90
Copy link
Member

/metal3-bmo-e2e-test

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Dec 21, 2023

/metal3-bmo-e2e-test

1 similar comment
@mquhuy
Copy link
Member Author

mquhuy commented Dec 21, 2023

/metal3-bmo-e2e-test

lentzi90
lentzi90 reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@mquhuy
Copy link
Member Author

mquhuy commented Dec 21, 2023

/cc @zaneb @kashifest @Rozzii

@mquhuy
Copy link
Member Author

mquhuy commented Dec 22, 2023

/cc @tuminoid @smoshiur1237

@maxrantil
Copy link

Nice, I like :)

@mquhuy
Copy link
Member Author

mquhuy commented Jan 8, 2024

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

kashifest
kashifest reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Improvement, one question inline. otherwise lgtm

test/e2e/common.go
}

func (input *BuildAndApplyKustomizeInput) validate() error {
if !input.WaitForDeployment && !input.WatchDeploymentLogs {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be && or ||, perhaps I am misunderstanding the use case but I would appreciate a comment here in the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be &&. Only if both of them are false then we don't need to validate the other inputs. I'll add the comment

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@mquhuy
E2E: Have a common function to install BMO and Ironic
bec9881 
Signed-off-by: Huy Mai <huy.mai@est.tech>
@kashifest
Copy link
Member

/approve
/lgtm
Since it got removed while adding the comment

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Jan 8, 2024

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot merged commit a93e15e into metal3-io:main Jan 8, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/refactor-e2e branch January 8, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@zaneb zaneb Awaiting requested review from zaneb

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mquhuy @metal3-io-bot @lentzi90 @maxrantil @kashifest